Autocompletion #61
Merged
Autocompletion #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fatme
force-pushed
the
fatme/autocompletion
branch
from
0dc855d to
a27eefb
Compare
| } | ||
|
|
||
| if(scriptsOk) { | ||
| console.log("Restart your shell to enable command auto-completion."); |
There was a problem hiding this comment.
Not a merge stopper, but why not using $logger?
There was a problem hiding this comment.
Due to copy paste driven development 😄
Fatme
force-pushed
the
fatme/autocompletion
branch
from
334322c to
5eb9f2f
Compare
|
|
||
| private updateBashProfile(): IFuture<void> { | ||
| return (() => { | ||
| var callProfileScript = |
There was a problem hiding this comment.
Consider making this a constant (private static class member)
There was a problem hiding this comment.
Do you change it? If so, it is clearly a var. But if it is a constant, lets make it official!
|
We discussed the issues in person and here's mine 👍. squash & go! |
Fatme
force-pushed
the
fatme/autocompletion
branch
from
5eb9f2f to
91fb9ce
Compare
rigor789
pushed a commit
that referenced
this pull request
Feb 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should be merged after this telerik/mobile-cli-lib#33