Open web inspector frontend in a standalone application instead of Safari #604
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
|
👍 |
| @@ -204,12 +205,15 @@ class IOSDebugService implements IDebugService { | |||
|
|
|||
| private openDebuggingClient(): IFuture<void> { | |||
| return (() => { | |||
| var cmd = "open -a Safari " + this.getSafariPath().wait(); | |||
| var inspectorPath = this.getInspectorPath().wait(); | |||
There was a problem hiding this comment.
It is better to use let instead of var here.
…lize the updated web inspector frontend. So open the application instead of Safari, because Safari is not able to render the frontend properly
KristinaKoeva
force-pushed
the
KristinaKoeva/DebuggingFix
branch
from
c363ccf to
29a7a97
Compare
|
ping @ligaz @teobugslayer |
|
👍 |
1 similar comment
|
👍 |
KristinaKoeva
added a commit
that referenced
this pull request
Jul 3, 2015
Open web inspector frontend in a standalone application instead of Safari
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The update of JavaScriptCore that we use in the iOS bridge goes with an updated web inspector frontend. The updated frontend is not rendered properly in latest Safari, so as a workaround open an application that would be distributed with the iOS bridge package
Related to NativeScript/ios-jsc#201