-
-
Notifications
You must be signed in to change notification settings - Fork 197
Do not init new project when install command is executed #603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ |
💯 |
https://github.com/NativeScript/nativescript-cli/blob/fatme/install/lib/commands/install.ts#L4 - this line should be removed, it is not used anymore |
@@ -9,8 +9,10 @@ export class InstallCommand implements ICommand { | |||
constructor(private $fs: IFileSystem, | |||
private $errors: IErrors, | |||
private $logger: ILogger, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fs
, errors
and logger
are not used anywhere
Maybe this is out of the scope for current PR, but I've tried using {
"nativescript": {
"id": "org.nativescript.app1004",
"tns-android": {
"version": "*"
}
},
"dependencies": {
"lodash": "^3.9.3"
}
} And the result is:
Same happened when I tried Do we want to support such versions? |
@rosen-vladimirov -definitely outside the scope of this PR. I think we should support such versions but we may wait until the need raises. |
I totally agree with @teobugslayer . |
✅ |
👍 after green build |
Do not init new project when install command is executed
No description provided.