Skip to content

Do not init new project when install command is executed #603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2015

Conversation

Fatme
Copy link
Contributor

@Fatme Fatme commented Jun 29, 2015

No description provided.

@Fatme Fatme added this to the 1.1.2 milestone Jun 29, 2015
@Fatme Fatme self-assigned this Jun 29, 2015
@ns-bot
Copy link

ns-bot commented Jun 29, 2015

@dtopuzov
Copy link
Contributor

💯

@rosen-vladimirov
Copy link
Contributor

https://github.com/NativeScript/nativescript-cli/blob/fatme/install/lib/commands/install.ts#L4 - this line should be removed, it is not used anymore

@@ -9,8 +9,10 @@ export class InstallCommand implements ICommand {
constructor(private $fs: IFileSystem,
private $errors: IErrors,
private $logger: ILogger,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fs, errors and logger are not used anywhere

@rosen-vladimirov
Copy link
Contributor

Maybe this is out of the scope for current PR, but I've tried using * for tns-android:

{
        "nativescript": {
                "id": "org.nativescript.app1004",
                "tns-android": {
                        "version": "*"
                }
        },
        "dependencies": {
                "lodash": "^3.9.3"
        }
}

And the result is:

Copying template files...
Failed to retrieve data from npm. Please try again a little bit later.. Error: Error: ENOENT, stat 'C:\Users\vladimirov\AppData\Roaming\npm-cache\tns-android\*\package'

Same happened when I tried ^1.1.0

Do we want to support such versions?

@teobugslayer
Copy link
Contributor

@rosen-vladimirov -definitely outside the scope of this PR. I think we should support such versions but we may wait until the need raises.

@Fatme
Copy link
Contributor Author

Fatme commented Jun 30, 2015

I totally agree with @teobugslayer .

@ns-bot
Copy link

ns-bot commented Jun 30, 2015

@rosen-vladimirov
Copy link
Contributor

👍 after green build

Fatme pushed a commit that referenced this pull request Jun 30, 2015
Do not init new project when install command is executed
@Fatme Fatme merged commit f95a53a into release Jun 30, 2015
@Fatme Fatme deleted the fatme/install branch June 30, 2015 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants