Android releated commands - platform add, prepare, build and platform list #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fatme
changed the title
Fatme
changed the title
| require("./bootstrap"); | ||
| require("./options"); | ||
|
|
||
| import errors = require("./common/errors"); | ||
| errors.installUncaughtExceptionListener(); | ||
|
|
||
| $injector.register("config", {"CI_LOGGER": false}); | ||
| $injector.register("config", {"CI_LOGGER": false, PROJECT_FILE_NAME: ".tnsproject", "DEBUG": true}); |
There was a problem hiding this comment.
We can't ship with DEBUG: true. I suggest you use an environment variable for the purpose, e.g. set NATIVESCRIPT_DEBUG=true before running tns commands.
Fatme
changed the title
|
Do we need the |
| export class PropertiesParser implements IPropertiesParser { | ||
| public createEditor(filePath: string) { | ||
| var future = new Future<any>(); | ||
| propertiesParser.createEditor(filePath, (err, data) => { |
There was a problem hiding this comment.
This pattern seems repeated with the one in NodePackageManager. Consider adding a helper similar to the one in the Q library. https://github.com/kriskowal/q/wiki/API-Reference#qnfbindnodefunc-args
There was a problem hiding this comment.
It's a good idea, but I think it would be better to do it in another PR. Agree?
|
👍 |
Fatme
added a commit
that referenced
this pull request
Jul 17, 2014
Android releated commands - platform add, prepare, build and platform list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.