Skip to content

fix: remove --legacy-peer-deps flag on install #5839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2025
Merged

fix: remove --legacy-peer-deps flag on install #5839

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions lib/bun-package-manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,10 +47,7 @@ export class BunPackageManager extends BasePackageManager {
const jsonContentBefore = this.$fs.readJson(packageJsonPath);

const flags = this.getFlagsString(config, true);
// TODO: Confirm desired behavior. The npm version uses --legacy-peer-deps
// by default, we could use `--no-peer` for Bun if similar is needed; the
// pnpm version uses `--shamefully-hoist`, but Bun has no similar flag.
let params = ["install", "--legacy-peer-deps"];
let params = ["install"];
const isInstallingAllDependencies = packageName === pathToSave;
if (!isInstallingAllDependencies) {
params.push(packageName);
Expand Down
2 changes: 1 addition & 1 deletion lib/node-package-manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ export class NodePackageManager extends BasePackageManager {
const jsonContentBefore = this.$fs.readJson(packageJsonPath);

const flags = this.getFlagsString(config, true);
let params = ["install", "--legacy-peer-deps"];
let params = ["install"];
const isInstallingAllDependencies = packageName === pathToSave;
if (!isInstallingAllDependencies) {
params.push(packageName);
Expand Down