Skip to content

feat: add android 35 support #5811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 19, 2024
Merged

feat: add android 35 support #5811

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/common/mobile/emulator-helper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import { injector } from "../yok";
export class EmulatorHelper implements Mobile.IEmulatorHelper {
// https://developer.android.com/guide/topics/manifest/uses-sdk-element
public mapAndroidApiLevelToVersion = {
"android-35": "15.0.0",
"android-34": "14.0.0",
"android-33": "13.0.0",
"android-32": "12.0.0",
Expand Down
1 change: 1 addition & 0 deletions packages/doctor/src/android-tools-info.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ export class AndroidToolsInfo implements NativeScriptDoctor.IAndroidToolsInfo {
"android-32",
"android-33",
"android-34",
"android-35",
];

const isRuntimeVersionLessThan = (targetVersion: string) => {
Expand Down
3 changes: 2 additions & 1 deletion packages/doctor/test/android-tools-info.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ describe("androidToolsInfo", () => {
"android-32",
"android-33",
"android-34",
"android-35",
];
}
},
Expand Down Expand Up @@ -138,7 +139,7 @@ describe("androidToolsInfo", () => {

it("runtime 8.2.0 should support android-17 - android-34", () => {
const min = 17;
const max = 34;
const max = 35;
assertSupportedRange("8.2.0", min, max);
assertSupportedRange("8.3.0", min, max);
});
Expand Down