Skip to content

[fix]: provide appId to webpack config #5778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 2, 2024

Conversation

farfromrefug
Copy link
Contributor

PR Checklist

What is the current behavior?

What is the new behavior?

Fixes/Implements/Closes #[Issue Number].

@cla-bot cla-bot bot added the cla: yes label Jan 15, 2024
@NathanWalker NathanWalker merged commit e3ef37d into NativeScript:main Feb 2, 2024
@vallemar
Copy link
Contributor

vallemar commented Feb 2, 2024

any documentation that for this?

@farfromrefug
Copy link
Contributor Author

@vallemar dont think so that part of the CLI is not really documented

@vallemar
Copy link
Contributor

vallemar commented Feb 3, 2024

@farfromrefug true, I thought that was here https://docs.nativescript.org/configuration/webpack

@rigor789
Copy link
Member

rigor789 commented Feb 3, 2024

They should be documented here:

image

Will add once we publish this.

@vallemar
Copy link
Contributor

vallemar commented Feb 3, 2024

@rigor789 When I saw that I thought that it could only be passed as a parameter in the terminal, can we add something quick that indicates that those flags can be passed through webpack and a simple example of one??? I would do it myself

@rigor789
Copy link
Member

rigor789 commented Feb 3, 2024

@vallemar these are internal flags, you wouldn't normally pass them via the terminal unless you're doing something completely out of the ordinary - like running webpack separately on it's own or whatever. The CLI passes these automatically based on nativescript config, and are then used by webpack config to set __ANDROID__ and so globals, enable/disable hmr etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 🏗 In progress
Development

Successfully merging this pull request may close these issues.

4 participants