fix(ios): correctly link non dynamic frameworks #5744
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now all frameworks were embedded and sign even though it should only happen with dynamic framework The code was there but the test was non working and thus all frameworks were embedded and signed. This is a better PR than NativeScript#5743 where we were supposing the framework name was the name of xcframework file. Now we use the info.plist
|
closing as it's dupe: #5759 |
|
@NathanWalker oh yes sorry ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now all frameworks were embedded and sign even though it should only happen with dynamic framework The code was there but the test was non working and thus all frameworks were embedded and signed.
This is a better PR than #5743 where we were supposing the framework name was the name of xcframework file. Now we use the info.plist
PR Checklist
What is the current behavior?
What is the new behavior?
Fixes/Implements/Closes #[Issue Number].