Skip to content

fix: hooks not being called #5729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 12, 2023
Merged

fix: hooks not being called #5729

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions lib/common/services/hooks-service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ import {
} from "../../definitions/project";
import { IInjector } from "../definitions/yok";
import { injector } from "../yok";
import { cache } from "../decorators";
import { memoize } from "../decorators";

class Hook implements IHook {
constructor(public name: string, public fullPath: string) {}
Expand Down Expand Up @@ -51,7 +51,14 @@ export class HooksService implements IHooksService {
return "hookArgs";
}

@cache()
@memoize({
shouldCache() {
// only cache if we have hooks directories, the only case to
// not have hooks directories is when the project dir is
// not set yet, ie. when creating a project.
return !!this.hooksDirectories.length;
},
})
private initialize(projectDir: string): void {
this.cachedHooks = {};

Expand Down