Skip to content

fix: codebuild destination warning #5564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 7, 2021
Merged

fix: codebuild destination warning #5564

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c1eb4b9
fix: xcodebuild destination warning
rigor789 Sep 3, 2021
731d402
test: update tests
rigor789 Sep 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions lib/services/ios/xcodebuild-args-service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,17 +38,15 @@ export class XcodebuildArgsService implements IXcodebuildArgsService {
let productType: ProductArgs;
if (this.$iOSWatchAppService.hasWatchApp(platformData, projectData)) {
productType = ProductArgs.scheme;
args = args.concat([
"-destination",
"generic/platform=iOS Simulator",
"CODE_SIGNING_ALLOWED=NO",
]);
args = args.concat(["CODE_SIGNING_ALLOWED=NO"]);
} else {
args = args.concat(["CODE_SIGN_IDENTITY="]);
}

args = args
.concat([
"-destination",
"generic/platform=iOS Simulator",
"build",
"-configuration",
buildConfig.release ? Configurations.Release : Configurations.Debug,
Expand Down Expand Up @@ -83,6 +81,8 @@ export class XcodebuildArgsService implements IXcodebuildArgsService {
projectData.projectName + ".xcarchive"
);
const args = [
"-destination",
"generic/platform=iOS",
"archive",
"-archivePath",
archivePath,
Expand Down
4 changes: 4 additions & 0 deletions test/services/ios/xcodebuild-args-service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,8 @@ describe("xcodebuildArgsService", () => {
const expectedArgs = [
"ONLY_ACTIVE_ARCH=NO",
"CODE_SIGN_IDENTITY=",
"-destination",
"generic/platform=iOS Simulator",
"build",
"-configuration",
configuration,
Expand Down Expand Up @@ -170,6 +172,8 @@ describe("xcodebuildArgsService", () => {
);

const expectedArgs = [
"-destination",
"generic/platform=iOS",
"archive",
"-archivePath",
path.join(buildOutputPath, `${projectName}.xcarchive`),
Expand Down