Skip to content

chore: remove privacy policy link #5494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 5, 2021
Merged

chore: remove privacy policy link #5494

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion lib/common/declarations.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -851,7 +851,6 @@ interface IAnalyticsSettingsService {
canDoRequest(): Promise<boolean>;
getUserId(): Promise<string>;
getClientName(): string;
getPrivacyPolicyLink(): string;
/**
* Gets current user sessions count.
* @param {string} projectName The analytics project id for which the counter should be taken.
Expand Down
3 changes: 0 additions & 3 deletions lib/common/test/unit-tests/analytics-service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,9 +62,6 @@ function createTestInjector(testScenario: ITestScenario): IInjector {
getClientName: () => {
return "UnitTests";
},
getPrivacyPolicyLink: () => {
return "privacy policy link";
},
getUserId: () => {
return Promise.resolve("UnitTestsUserId");
},
Expand Down
4 changes: 0 additions & 4 deletions lib/services/analytics-settings-service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,10 +48,6 @@ class AnalyticsSettingsService implements IAnalyticsSettingsService {
return "" + this.$staticConfig.CLIENT_NAME_ALIAS.cyan.bold;
}

public getPrivacyPolicyLink(): string {
return "http://www.telerik.com/company/privacy-policy";
}

public async getUserSessionsCount(projectName: string): Promise<number> {
const sessionsCountForProject = await this.$userSettingsService.getSettingValue<
number
Expand Down
9 changes: 1 addition & 8 deletions lib/services/analytics/analytics-service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,14 +69,7 @@ export class AnalyticsService implements IAnalyticsService, IDisposable {
)) &&
isInteractive()
) {
this.$logger.info(
"Do you want to help us improve " +
this.$analyticsSettingsService.getClientName() +
" by automatically sending anonymous usage statistics? We will not use this information to identify or contact you." +
" You can read our official Privacy Policy at"
);

const message = this.$analyticsSettingsService.getPrivacyPolicyLink();
const message = `Do you want to help us improve ${this.$analyticsSettingsService.getClientName()} by automatically sending anonymous usage statistics? We will not use this information to identify or contact you.`;
trackFeatureUsage = await this.$prompter.confirm(message, () => true);
await this.setStatus(
this.$staticConfig.TRACK_FEATURE_USAGE_SETTING_NAME,
Expand Down