Skip to content

fix: handle permissions error on directory creation #5480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 27, 2021
Merged

fix: handle permissions error on directory creation #5480

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0705bdf
fix: handle permissions error on directory creation
janoshrubos Jan 21, 2021
3419b4a
refactor: common error message
janoshrubos Jan 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion lib/common/file-system.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,16 @@ export class FileSystem implements IFileSystem {
}

public createDirectory(path: string): void {
mkdirp.sync(path);
try {
mkdirp.sync(path);
} catch (error) {
const $errors = this.$injector.resolve("errors");
let errorMessage = `Unable to create directory ${path}. \nError is: ${error}.`;
if (error.code === "EACCES") {
errorMessage += "\n\nYou may need to call the command with 'sudo'.";
}
$errors.fail(errorMessage);
}
}

public readDirectory(path: string): string[] {
Expand Down