Skip to content

perf: validate update version before backup #5479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 27, 2021
Merged

perf: validate update version before backup #5479

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5f3d5c1
perf: validate update version before backup
janoshrubos Jan 20, 2021
be91036
perf: no need to loop through all deps
rigor789 Jan 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions lib/controllers/update-controller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,21 @@ export class UpdateController
const projectData = this.$projectDataService.getProjectData(
updateOptions.projectDir
);

try {
// this is a preventive check to make sure the passed version exists before doing any backups, however
// the update can still fail if the specified tag doesn't exist in one of the updatableDependencies
// at this stage we only care to check a single dependency to catch invalid versions early.
await this.getVersionFromTag(
UpdateController.updatableDependencies[0].name,
updateOptions.version
);
} catch (error) {
this.$errors.fail(
`${UpdateController.updateFailMessage} Reason is: ${error.message}`
);
}

const backupDir = path.join(
updateOptions.projectDir,
UpdateController.backupFolder
Expand Down