Skip to content

fix: improve package-manager help and info messages #5267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 24, 2020
Merged

fix: improve package-manager help and info messages #5267

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/man_pages/general/package-manager-get.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,5 @@ General | `$ tns package-manager get`
Command | Description
----------|----------
[package-manager-set](package-manager-set.html) | Enables the specified package manager for the NativeScript CLI. Supported values are npm, yarn and pnpm.
[package-manager-get](package-manager-get.html) | Prints the value of the current package manager.
<% } %>
2 changes: 1 addition & 1 deletion docs/man_pages/general/package-manager-set.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ position: 18

### Description

Enables the specified package manager for the NativeScript CLI. Supported values are npm and yarn.
Enables the specified package manager for the NativeScript CLI. Supported values are npm, yarn and pnpm.

### Commands

Expand Down
1 change: 1 addition & 0 deletions docs/man_pages/start.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ Command | Description
[proxy](general/proxy.html) | Displays proxy settings.
[migrate](general/migrate.html) | Migrates the app dependencies to a form compatible with NativeScript 6.0.
[update](general/update.html) | Updates the project with the latest versions of iOS/Android runtimes and cross-platform modules.
[package-manager](general/package-manager.html) | Prints the value of the current package manager.

## Project Development Commands
Command | Description
Expand Down
1 change: 1 addition & 0 deletions lib/common/commands/package-manager-set.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ export class PackageManagerCommand implements ICommand {

await this.$userSettingsService.saveSetting("packageManager", packageManagerName);

this.$logger.printMarkdown(`Please ensure you have the directory containing \`${packageManagerName}\` executable available in your PATH.`);
this.$logger.printMarkdown(`You've successfully set \`${packageManagerName}\` as your package manager.`);
}
}
Expand Down