fix: temporary files created by CLI are not deleted in some cases #5238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently CLI relies on temp module to create temporary files, which should be deleted once CLI process has no work left. However, in some cases, when Node.js crashes (or the process is killed with a signal) the temp module is unable to delete the files. In order to fix this, introduce a tempService wrapper for temp module. For each path created by temp module, add a new cleanup action in the CLI's cleanup service, which will take care to delete the files even when the main CLI process dies with unusual error.
|
test cli-run cli-plugin cli-misc cli-debug |
|
test cli-run cli-plugin cli-misc cli-debug cli-device |
|
Fails are not caused by this PR, so merging the changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently CLI relies on temp module to create temporary files, which should be deleted once CLI process has no work left. However, in some cases, when Node.js crashes (or the process is killed with a signal) the temp module is unable to delete the files.
In order to fix this, introduce a tempService wrapper for temp module. For each path created by temp module, add a new cleanup action in the CLI's cleanup service, which will take care to delete the files even when the main CLI process dies with unusual error.
PR Checklist
What is the current behavior?
What is the new behavior?
Fixes issue #5239