fix: removed native code should be cleaned from native project #5225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently in case you have native source code, it is added to the pbxproject's references. In case you remove the source code's directory, the files relations are not cleaned from the pbxproject, which makes the build fail. To fix this, instead of skipping the native code refrence for this folder, just call the method to add such pbxgroup and the nativescript-dev-xcode will cleanup the required resources. Also fix the warning for modulemaps, it must be shown only when you have `.h` files and you do not have module.modulemap file at the root of the source code directory.
|
test cli-smoke |
|
test cli-smoke ios-runtime-tests-xcode11 |
DimitarTachev
approved these changes
Jan 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently in case you have native source code, it is added to the pbxproject's references. In case you remove the source code's directory, the files relations are not cleaned from the pbxproject, which makes the build fail. To fix this, instead of skipping the native code refrence for this folder, just call the method to add such pbxgroup and the nativescript-dev-xcode will cleanup the required resources.
Also fix the warning for modulemaps, it must be shown only when you have
.hfiles and you do not have module.modulemap file at the root of the source code directory.PR Checklist
Fixes/Implements/Closes #[Issue Number].