Skip to content

This PR add pnpm full support #5217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 23, 2020
Merged

Conversation

farfromrefug
Copy link
Contributor

PR Checklist

What is the new behavior?

you can choose pnpm as the package manager

@rosen-vladimirov
Copy link
Contributor

Hey @farfromrefug ,
Thanks a lot for the contribution. Can you please fix the linting error, so we can run some tests. Currently building of the package fails with:

ERROR: /home/travis/build/NativeScript/nativescript-cli/lib/package-manager.ts:104:9 - missing whitespace

@cla-bot cla-bot bot added the cla: yes label Jan 16, 2020
@farfromrefug
Copy link
Contributor Author

@rosen-vladimirov done. BTW for now i use --shamefully-hoist option for pnpm. We get to much errors without it. Might change that in the future if i manage to fix it.

@rosen-vladimirov
Copy link
Contributor

test cli-smoke cli-templates

@rosen-vladimirov
Copy link
Contributor

Hey @farfromrefug ,
I've tested your PR locally and it works awesome, great work! The only thing I've noticed is the command tns plugin remove <plugin name> fails with error. For example, in my case:

tns plugin remove nativescript-ui-listview
Command failed: pnpm remove nativescript-ui-listview --save
 ERROR  Unknown option 'save'

Can you please take a look at this issue? After that we can merge this PR.

@farfromrefug
Copy link
Contributor Author

My bad! Will fix it this morning.

@rosen-vladimirov
Copy link
Contributor

Hey @farfromrefug ,
Did you have a chance to take a look at the issue? If you want, I can try to take a look at it and push a fix

@rosen-vladimirov
Copy link
Contributor

test cli-smoke

@rosen-vladimirov
Copy link
Contributor

This PR implements #4654

Copy link
Contributor

@rosen-vladimirov rosen-vladimirov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! Thanks for your contribution!

@rosen-vladimirov rosen-vladimirov merged commit d4c2bf0 into NativeScript:master Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants