Skip to content

fix: improve message for Android socket connection error #5207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 13, 2020

Conversation

rosen-vladimirov
Copy link
Contributor

In case there's a socket connection error during LiveSync for Android, we show a non-descriptive error message which confuses the users. Improve the messsage with suggestions what might cause the error.

PR Checklist

What is the current behavior?

In case you change your application identifier in <path to App_Resources>/Android/app.gradle:

android {
  defaultConfig {
    minSdkVersion 17
    generatedDensities = []
    applicationId = "org.nativescript.different"
  }
  aaptOptions {
    additionalParameters "--no-version-vectors"
  }
}

And run tns run android you'll see: https://www.screencast.com/t/fWQeEVdQ

What is the new behavior?

https://www.screencast.com/t/0CskhIc0IP

Fixes issue: #3818

In case there's a socket connection error during LiveSync for Android, we show a non-descriptive error message which confuses the users. Improve the messsage with suggestions what might cause the error.
@rosen-vladimirov rosen-vladimirov self-assigned this Jan 10, 2020
@cla-bot cla-bot bot added the cla: yes label Jan 10, 2020
@rosen-vladimirov
Copy link
Contributor Author

test cli-run cli-smoke

@rosen-vladimirov rosen-vladimirov merged commit 543c522 into release Jan 13, 2020
@rosen-vladimirov rosen-vladimirov deleted the vladimirov/improve-socket-error branch January 13, 2020 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants