Skip to content

fix: Add warning for missing modulemap in src #5188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 19, 2019
Merged

fix: Add warning for missing modulemap in src #5188

merged 1 commit into from
Dec 19, 2019

Conversation

mbektchiev
Copy link
Contributor

PR Checklist

Fixes issue #5187

@mbektchiev mbektchiev added os: ios needs better error msg prepare Describes issues related to prepare command labels Dec 18, 2019
@mbektchiev mbektchiev self-assigned this Dec 18, 2019
@cla-bot cla-bot bot added the cla: yes label Dec 18, 2019
@mbektchiev mbektchiev force-pushed the bektchiev/warn-missing-modulemap branch from 7bd188d to 9144d5c Compare December 18, 2019 13:42
@mbektchiev mbektchiev merged commit 7c692ee into master Dec 19, 2019
@mbektchiev mbektchiev deleted the bektchiev/warn-missing-modulemap branch December 19, 2019 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DimitarTachev DimitarTachev DimitarTachev approved these changes

@rosen-vladimirov rosen-vladimirov Awaiting requested review from rosen-vladimirov

Assignees

@mbektchiev mbektchiev

Labels
cla: yes needs better error msg os: ios prepare Describes issues related to prepare command
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mbektchiev @DimitarTachev