feat: allow tag and range versions in the preview app plugin versions validation #5104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fatme
reviewed
Oct 30, 2019
lib/services/livesync/playground/preview-app-plugins-service.ts
Outdated
Show resolved
Hide resolved
DimitarTachev
force-pushed
the
tachev/fix-preview-plugins-version
branch
from
ce188ac to
29f40ee
Compare
|
test cli-preview |
Fatme
approved these changes
Oct 30, 2019
endarova
approved these changes
Oct 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
The CLI requires hardcoded plugin versions from the Preview app.
What is the new behavior?
The CLI supports any version formats from the Preview app (hardcoded, tag and range).