fix: do not require signing when the aab will not be deployed by the CLI #5085

DimitarTachev · 2019-10-18T05:45:39Z

PR Checklist

The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages.
There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
You have signed the CLA.
All existing tests are passing: https://github.com/NativeScript/nativescript-cli/blob/master/CONTRIBUTING.md#contribute-to-the-code-base
Tests for the changes are included.

tns build android --aab requires signing options.

tns build android --aab does not require signing options as we won't produce apks and deploy on device.

DimitarTachev · 2019-10-18T05:45:50Z

test cli-build

fix: do not require signing when the aab will not be deployed by the CLI

2d6d2ed

cla-bot bot added the cla: yes label Oct 18, 2019

Fatme approved these changes Oct 18, 2019

View reviewed changes

DimitarTachev merged commit a65a6ac into release Oct 18, 2019

DimitarTachev deleted the tachev/fix-build-aab branch October 18, 2019 06:54

Fatme added the no-changelog The issue is present only in `next` versions and was not included in official version. label Nov 1, 2019