Skip to content

fix: add more signing validations #5079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 17, 2019
Merged

fix: add more signing validations #5079

merged 1 commit into from
Oct 17, 2019

Conversation

DimitarTachev
Copy link
Contributor

PR Checklist

What is the current behavior?

The errors for missing Android signing options with aab are misleading.

What is the new behavior?

The Android signing is validated in the commands and the errors are more clear.

Related to: #5049

@cla-bot cla-bot bot added the cla: yes label Oct 16, 2019
@DimitarTachev
Copy link
Contributor Author

test cli-smoke cli-device cli-debug cli-run

1 similar comment
@DimitarTachev
Copy link
Contributor Author

test cli-smoke cli-device cli-debug cli-run

Fatme
Fatme reviewed Oct 17, 2019
View reviewed changes
@DimitarTachev
Copy link
Contributor Author

test cli-smoke cli-device cli-debug cli-run

@DimitarTachev
Copy link
Contributor Author

test cli-smoke cli-device cli-debug cli-run

@Fatme
Copy link
Contributor

Fatme commented Oct 17, 2019

test cli-smoke cli-device cli-debug cli-run

1 similar comment
@DimitarTachev
Copy link
Contributor Author

test cli-smoke cli-device cli-debug cli-run

@KristianDD KristianDD merged commit e85406e into master Oct 17, 2019
@KristianDD KristianDD deleted the tachev/run-with-aab branch October 17, 2019 15:29
@Fatme Fatme added the no-changelog The issue is present only in `next` versions and was not included in official version. label Nov 1, 2019
@Fatme Fatme added this to the 6.2.0 milestone Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fatme Fatme Fatme approved these changes

Assignees
No one assigned
Labels
cla: yes no-changelog The issue is present only in `next` versions and was not included in official version.
Projects
None yet
Milestone
6.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@DimitarTachev @Fatme @KristianDD