feat: support aab in run and deploy #5078

DimitarTachev · 2019-10-15T08:25:07Z

PR Checklist

The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages.
There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
You have signed the CLA.
All existing tests are passing: https://github.com/NativeScript/nativescript-cli/blob/master/CONTRIBUTING.md#contribute-to-the-code-base
Tests for the changes are included.

The run and deploy commands are not able to be executed with --aab.

We are able to be run and deploy with --aab.

Related to: #5049

lib/definitions/build.d.ts

lib/common/mobile/android/android-application-manager.ts

DimitarTachev · 2019-10-15T11:42:44Z

test cli-smoke

DimitarTachev · 2019-10-15T12:15:14Z

test cli-smoke

cla-bot bot added the cla: yes label Oct 15, 2019

DimitarTachev force-pushed the tachev/run-with-aab branch from b06eb07 to c72536f Compare October 15, 2019 08:34

KristianDD reviewed Oct 15, 2019

View reviewed changes

lib/definitions/build.d.ts Outdated Show resolved Hide resolved

KristianDD reviewed Oct 15, 2019

View reviewed changes

lib/common/mobile/android/android-application-manager.ts Outdated Show resolved Hide resolved

KristianDD approved these changes Oct 15, 2019

View reviewed changes

DimitarTachev force-pushed the tachev/run-with-aab branch from c72536f to e0b4353 Compare October 15, 2019 11:42

feat: support aab in run and deploy

902d369

DimitarTachev force-pushed the tachev/run-with-aab branch from e0b4353 to 902d369 Compare October 15, 2019 12:15

DimitarTachev merged commit 049cc2d into master Oct 15, 2019

DimitarTachev deleted the tachev/run-with-aab branch October 15, 2019 13:03