Skip to content

fix: fix definition files so nativescript-cloud can be successfully built #5057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 8, 2019

Conversation

Fatme
Copy link
Contributor

@Fatme Fatme commented Oct 8, 2019

Currently nativescript-cloud cannot be built with latest master branch of CLI due to the following errors:

node_modules/nativescript/lib/definitions/project.d.ts(476,96): error TS2503: Cannot find namespace 'IXcode'.
node_modules/nativescript/lib/definitions/project.d.ts(476,165): error TS2503: Cannot find namespace 'IXcode'.
node_modules/nativescript/lib/definitions/project.d.ts(479,128): error TS2503: Cannot find namespace 'IXcode'.
node_modules/nativescript/lib/definitions/project.d.ts(480,99): error TS2503: Cannot find namespace 'IXcode'.

The issue happens as IXcode interface is already used from project.d.ts file. As nativescript-cloud lib generates references.d.ts file with references to all .d.ts files from NativeScript CLI, we need a separate .d.ts file for IXcode interface. This way, it will be included in the generated references.d.ts file and cloud-lib will be successfully built.

PR Checklist

What is the current behavior?

What is the new behavior?

Fixes/Implements/Closes #[Issue Number].

…uilt

Currently `nativescript-cloud` cannot be built with latest master branch of CLI due to the following errors:
```
node_modules/nativescript/lib/definitions/project.d.ts(476,96): error TS2503: Cannot find namespace 'IXcode'.
node_modules/nativescript/lib/definitions/project.d.ts(476,165): error TS2503: Cannot find namespace 'IXcode'.
node_modules/nativescript/lib/definitions/project.d.ts(479,128): error TS2503: Cannot find namespace 'IXcode'.
node_modules/nativescript/lib/definitions/project.d.ts(480,99): error TS2503: Cannot find namespace 'IXcode'.
```

The issue happens as `IXcode` interface is already used from project.d.ts file. As `nativescript-cloud` lib generates `references.d.ts` file with references to all `.d.ts` files from NativeScript CLI, we need a separate `.d.ts`  file for `IXcode` interface. This way, it will be included in the generated `references.d.ts` file and cloud-lib will be successfully built.
@cla-bot cla-bot bot added the cla: yes label Oct 8, 2019
@Fatme Fatme merged commit 08dd3b1 into master Oct 8, 2019
@Fatme Fatme deleted the fatme/fix-xcode-definitions branch October 8, 2019 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants