Create project command #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| $injector.requireCommand("create", "./commands/create-project-command"); | ||
|
|
||
| $injector.require("nodePackageManager", "./node-package-manager"); |
There was a problem hiding this comment.
I tried it but the module that is in package.json is also named npm :)
There was a problem hiding this comment.
That shouldn't be a problem, I think. The package is resolved using require('npm') and our class is resolved using yok, so there shouldn't be a collision.
|
@tailsu I addressed all your comments. I suggest to extract common blocks in another PR. Agree? |
|
Better do it now as we keep postponing these clean-ups and it slows us down in the long term. |
1 similar comment
| "p" : "path" | ||
| }; | ||
|
|
||
| var defaultProfileDir = path.join(process.env.USERPROFILE || osenv.home() || process.env.HOMEPATH, ".nativescript-cli"); |
|
👍 |
| this.$errors.fail("Path already exists and is not empty %s", projectDir); | ||
| } | ||
|
|
||
| this.$logger.trace("Creating a new NativeScript project with name %s and id at location", projectName, projectId, projectDir); |
|
goot catch :) I'll fix it. |
rigor789
pushed a commit
that referenced
this pull request
Feb 7, 2022
…ys-info Add more methods to sys info
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.