Skip to content

fix: add (empty) settings.gradle file to mark build as independent #4996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 9, 2019

Conversation

madmas
Copy link
Contributor

@madmas madmas commented Aug 30, 2019

Solves #4995

Adding an settings.gradle file marks the gradle build as a independent build and avoids conflicts with other gradle build

PR Checklist

What is the current behavior?

Build fails if a gradle build is part of the wrapping project.

What is the new behavior?

Build succeeds as expected.

Fixes/Implements/Closes #4995 .

Solves NativeScript#4995 

Adding an settings.gradle file marks the gradle build as a independent build and avoids conflicts with other gradle build
@cla-bot cla-bot bot added the cla: yes label Aug 30, 2019
@rosen-vladimirov
Copy link
Contributor

test cli-build

@rosen-vladimirov
Copy link
Contributor

test cli-build cli-android

@DimitarTachev DimitarTachev changed the base branch from master to release September 11, 2019 05:56
@rosen-vladimirov rosen-vladimirov changed the base branch from release to master October 9, 2019 07:48
@rosen-vladimirov rosen-vladimirov merged commit 72a4cd5 into NativeScript:master Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Building plugin and running demo app fails if plugins has a surrounding gradle build
2 participants