fix: ensure data is sent to analytics on preuninstall #4989
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introudce finishTracking method in `analyticsService` which will ensure all pending information is send to Google Analytics. This is required for some rare cases in which we want to be sure all the information has been sent.
CLI's analytics process is a detached one, so during `preuninstall` command, CLI just sends information to the detached process what should be tracked and finishes CLI's execution. After that `npm` starts removing the CLI package and its `node_modules`. At this point the analytics process may still work and trying to send data, but as it relies on components in node_modules, which npm currently deletes, it fails to send information to Google Analytics. To ensure correct data is send to Analytics, ensure tracking is finished before ending the preuninstall command.
In case the environment variable `NS_CLI_PREUNINSTALL_ANALYTICS_LOG_FILE` is set and `npm un -g nativescript` or `npm i -g nativescript` is executed, CLI will use the value of the variable as path for the analyticsLogFile. This way it will be easy to check what information is tracked during install/uninstall of the CLI.
rosen-vladimirov
force-pushed
the
vladimirov/update-feedback-analytics
branch
from
4c92f8e to
bab894d
Compare
|
test cli-smoke |
Fatme
approved these changes
Aug 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: enable to possibility to ensure analytics tracking is finished
Introudce finishTracking method in
analyticsServicewhich will ensure all pending information is send to Google Analytics. This is required for some rare cases in which we want to be sure all the information has been sent.fix: ensure data is sent to analytics on preuninstall
CLI's analytics process is a detached one, so during
preuninstallcommand, CLI just sends information to the detached process what should be tracked and finishes CLI's execution. After thatnpmstarts removing the CLI package and itsnode_modules.At this point the analytics process may still work and trying to send data, but as it relies on components in node_modules, which npm currently deletes, it fails to send information to Google Analytics.
To ensure correct data is send to Analytics, ensure tracking is finished before ending the preuninstall command.
feat: create analyticsLogFile during preuninstall
In case the environment variable
NS_CLI_PREUNINSTALL_ANALYTICS_LOG_FILEis set andnpm un -g nativescriptornpm i -g nativescriptis executed, CLI will use the value of the variable as path for the analyticsLogFile. This way it will be easy to check what information is tracked during install/uninstall of the CLI.PR Checklist
What is the current behavior?
During uninstall of CLI, some information may not be send to analytics.
What is the new behavior?
During uninstall of CLI, all information that must be tracked will be send to Google Analytics.
Related to #4974