feat: open feedback form when CLI is uninstalled #4973
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case CLI is uninstalled, open a feedback form, so the user might explain why they've uninstalled the product. Add analytics tracking for the uninstall call. Remove the `disableAnalytics` property of the `dev-preuninstall` command - this way we'll receive information for the number of times the command has been executed (usually it is called from CLI's preuninstall script). Also add custom data in the analytics, so we'll be able to generate report to see how many times users uninstall the CLI (actually executing `npm uninstall...`) and if this happens from interactive terminal.
|
test cli-smoke |
KristianDD
approved these changes
Aug 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case CLI is uninstalled, open a feedback form, so the user might explain why they've uninstalled the product.
Add analytics tracking for the uninstall call. Remove the
disableAnalyticsproperty of thedev-preuninstallcommand - this way we'll receive information for the number of times the command has been executed (usually it is called from CLI's preuninstall script).Also add custom data in the analytics, so we'll be able to generate report to see how many times users uninstall the CLI (actually executing
npm uninstall...) and if this happens from interactive terminal.PR Checklist
What is the current behavior?
When you execute
npm uninstall -g nativescript, CLI removes several directories and does not collect any information about the action and why it has been executed by the user.What is the new behavior?
CLI collects information in analytics when the preuninstall action is executed. In case the command was actually
npm uninstall...and the terminal is interactive, CLI will open a feedback form, where the user can describe why the product has been uninstalled.Implements issue #4974