Skip to content

fix: speed up the prepare process #4972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 28, 2019
Merged

fix: speed up the prepare process #4972

merged 1 commit into from
Aug 28, 2019

Conversation

Fatme
Copy link
Contributor

@Fatme Fatme commented Aug 26, 2019

Currently CLI executes which pod and which xcodeproj every time when pod install is executed e.g on every native change. Also, CLI checks if env is correctly setup on every "prepare" related command - e.g prepare, build, run, debug and test. However, which xcodeproj
and pod --version are included in the checks for correctly setup env. So these checks shouldn't be executed before each pod install as it aditionally slow down the prepare process.

Currently CLI checks if xcproj executable is available on user's machine in case when CocoaPods version is lower than 1.0.0 and Xcode's version is greater than 7.3 and uses it to convert the project to ASCII plist format. This logic was needed as there is an issue in case when CocoaPods is with version lower than 1.0.0 and Xcode is with version >= 7.3.0 - all .pbxproject files are converted to XML plst format. However, CLI requires Xcode 10 as min supported version and based on this blog post it seems it is not possible to use CocoaPods with version lower than 1.0.0 and Xcode 10+.

Rel to: #4971

PR Checklist

What is the current behavior?

What is the new behavior?

Fixes/Implements/Closes #[Issue Number].

@cla-bot cla-bot bot added the cla: yes label Aug 26, 2019
@Fatme
Copy link
Contributor Author

Fatme commented Aug 26, 2019

test cli-templates

@rosen-vladimirov
Copy link
Contributor

test cli-prepare cli-device cli-run

Copy link
Contributor

@rosen-vladimirov rosen-vladimirov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really awesome work!
Merge after green build

@rosen-vladimirov
Copy link
Contributor

test cli-device

1 similar comment
@miroslavaivanova
Copy link
Contributor

test cli-device

@Fatme Fatme merged commit 8ec6798 into master Aug 28, 2019
@Fatme Fatme deleted the fatme/remove-unneeded-code branch August 28, 2019 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants