fix: handle changes in runtimes logs #4968
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test cli-device cli-run cli-templates cli-smoke |
rosen-vladimirov
force-pushed
the
vladimirov/fix-logs
branch
3 times, most recently
from
9fdf86b to
3f55217
Compare
|
test cli-device cli-run cli-templates cli-smoke cli-debug |
KristianDD
reviewed
Aug 26, 2019
KristianDD
reviewed
Aug 26, 2019
KristianDD
reviewed
Aug 26, 2019
In 6.1.0 there are several changes in the way both runtimes print logs. In order to handle this and keep the logs as they were with previous versions, introduce a check for the runtime version. In case the version is 6.1.0 or later (including prerelease versions) CLI will just replace the file reference in the message. For older versions CLI will still change the format of the message. Add integration tests for the whole CLI logic for parsing the logs - the input of the tests is the real output from device and the tests verify CLI will print the expected messages to the output. In the resources of the test you can find .zip file containing the project used for running the tests. In case additional verifications are needed, unzip the content and add required tests.
rosen-vladimirov
force-pushed
the
vladimirov/fix-logs
branch
from
3f55217 to
d794ea6
Compare
|
test cli-device cli-run cli-smoke |
KristianDD
approved these changes
Aug 27, 2019
|
test cli-device cli-run cli-smoke cli-debug |
|
test cli-device |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 6.1.0 there are several changes in the way both runtimes print logs. In order to handle this and keep the logs as they were with previous versions, introduce a check for the runtime version. In case the version is 6.1.0 or later (including prerelease versions) CLI will just replace the file reference in the message. For older versions CLI will still change the format of the message.
Add integration tests for the whole CLI logic for parsing the logs - the input of the tests is the real output from device and the tests verify CLI will print the expected messages to the output. In the resources of the test you can find .zip file containing the project used for running the tests. In case additional verification are needed, unzip the content and add required tests.
PR Checklist
What is the current behavior?
CLI prints messages generated by Android runtime 6.1.0 and iOS Runtime 6.1.0 incorrectly.
What is the new behavior?
CLI prints messages generated by Android runtime 6.1.0 and iOS Runtime 6.1.0 incorrectly.
Implements issue #4976