Skip to content

feat(publish): ability to publish applications using Xcode 11 #4965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 26, 2019

Conversation

Fatme
Copy link
Contributor

@Fatme Fatme commented Aug 23, 2019

As Application Loader is no longer included in Xcode 11, CLI is not able to find the path to itmsTransporter and throws an error. However, itmsTransporter app is already part of ContentDeliveryServices.framework which is part of SharedFrameworks which are included in Xcode 11 itself. So this PR returns the correct path to itmsTransporter app based on xcode's version.
Also this PR checks first if the path to itmsTransporter exists and after that builds the application.

Currently getXcodeVersion always returns { major: null, minor: null, patch: null }. This method uses internally sysInfo.getXcodeVersion(). On the other side, sysInfo.getXcodeVersion() returns the xocde's version in format major.minor.patch - for example 10.3.4. After getting the result of sysInfo.getXcodeVersion(), NativeScript CLI matches the received output with /Xcode (.*)/ regex. As the received output doesn't contain Xcode, the match always returns null and as result getXcodeVersion() always returns { major: null, minor: null, patch: null }.

Rel to: #4908

PR Checklist

What is the current behavior?

What is the new behavior?

Fixes/Implements/Closes #[Issue Number].

Fatme added 2 commits August 23, 2019 00:05
As `Application Loader` is no longer included in Xcode 11, CLI is not able to find the path to itmsTransporter and throws an error. However, itmsTransporter app is already part of ContentDeliveryServices.framework which is part of SharedFrameworks which are included in Xcode 11 itself. So this PR returns the correct path to itmsTransporter app based on xcode's version.
Currently `getXcodeVersion` always returns `{ major: null, minor: null, patch: null }`. This method uses internally `sysInfo.getXcodeVersion()`. On the other side, `sysInfo.getXcodeVersion()` returns the xocde's version in format `major.minor.patch` - for example `10.3.4`. After getting the result of `sysInfo.getXcodeVersion()`, NativeScript CLI matches the received output with `/Xcode (.*)/` regex. As the received output doesn't contain `Xcode`, the match returns null and as result `getXcodeVersion` method returns `{ major: null, minor: null, patch: null }`.
@cla-bot cla-bot bot added the cla: yes label Aug 23, 2019
@Fatme Fatme merged commit 2fc81c5 into master Aug 26, 2019
@Fatme Fatme deleted the fatme/publish-xcode-11 branch August 26, 2019 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants