feat(publish): ability to publish applications using Xcode 11 #4965
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As
Application Loader
is no longer included in Xcode 11, CLI is not able to find the path to itmsTransporter and throws an error. However,itmsTransporter
app is already part ofContentDeliveryServices.framework
which is part ofSharedFrameworks
which are included inXcode 11
itself. So this PR returns the correct path to itmsTransporter app based on xcode's version.Also this PR checks first if the path to itmsTransporter exists and after that builds the application.
Currently
getXcodeVersion
always returns{ major: null, minor: null, patch: null }
. This method uses internallysysInfo.getXcodeVersion()
. On the other side,sysInfo.getXcodeVersion()
returns the xocde's version in formatmajor.minor.patch
- for example10.3.4
. After getting the result ofsysInfo.getXcodeVersion()
, NativeScript CLI matches the received output with/Xcode (.*)/
regex. As the received output doesn't containXcode
, the match always returns null and as resultgetXcodeVersion()
always returns{ major: null, minor: null, patch: null }
.Rel to: #4908
PR Checklist
What is the current behavior?
What is the new behavior?
Fixes/Implements/Closes #[Issue Number].