Skip to content

fix: certificates and provision parsing should work on macOS Catalina #4962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 20, 2019

Conversation

rosen-vladimirov
Copy link
Contributor

Currently, in case you pass --provision to tns prepare/build/run/debug/test command and you have macOS Catalina installed, CLI fails with error: Expected "SHA-1 hash: " or end of input but "S" found.
The problem is that the security command used by ios-mobileprovision-finder package has a different output in macOS Catalina. To fix this, update the ios-mobileprovision-finder version.

PR Checklist

What is the current behavior?

Running tns prepare ios --provision fails on macOS Catalina.

What is the new behavior?

CLI can parse certificates and provsions on macOS Catalina, i.e. tns prepare ios --provision shows correct output.

Fixes issue #4934

Currently, in case you pass `--provision` to `tns prepare/build/run/debug/test` command and you have macOS Catalina installed, CLI fails with error: `Expected "SHA-1 hash: " or end of input but "S" found`.
The problem is that the `security` command used by `ios-mobileprovision-finder` package has a different output in macOS Catalina. To fix this, update the ios-mobileprovision-finder version.
@rosen-vladimirov rosen-vladimirov self-assigned this Aug 20, 2019
@cla-bot cla-bot bot added the cla: yes label Aug 20, 2019
@rosen-vladimirov
Copy link
Contributor Author

test cli-device cli-debug cli-smoke

@Natalia-Hristova Natalia-Hristova self-requested a review August 20, 2019 12:55
@rosen-vladimirov rosen-vladimirov merged commit 5988e8a into master Aug 20, 2019
@rosen-vladimirov rosen-vladimirov deleted the vladimirov/fix-provision-catalina branch August 20, 2019 12:56
@two-bridges
Copy link

two-bridges commented Oct 11, 2019

Re.

To fix this, update the ios-mobileprovision-finder version

This worked for me (tns version v5.4):

cd $(npm config get prefix)/lib/node_modules/nativescript
npm install [email protected]

@Codex-
Copy link

Codex- commented Feb 12, 2020

@two-bridges you just saved me a ton of time and headaches, thank you so much. Can confirm that this resolved the issue for myself, this issue popped up after upgrading a build agent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants