Skip to content

fix: remove usages of logger.out in CLI code #4960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 19, 2019

Conversation

rosen-vladimirov
Copy link
Contributor

logger.out has been removed before 6.0 release, but it has still been used in CLI's code. Remove its usages and add tests for errors.beginCommand (the one where the method has been used until now.

PR Checklist

What is the current behavior?

ANDROID_HOME=/invalid tns doctor - fails and in interactive terminal prompts you to select option. If you choose Manually configure, CLI will print error this.$injector.resolve(...).out is not a function (NOTE: In non-interactive terminal the same happens).

What is the new behavior?

ANDROID_HOME=/invalid tns doctor - fails and in interactive terminal prompts you to select option. If you choose Manually configure, CLI will prints where are the system requirements.

Fixes issue #4958

`logger.out` has been removed before 6.0 release, but it has still been used in CLI's code. Remove its usages and add tests for `errors.beginCommand` (the one where the method has been used until now.
@rosen-vladimirov rosen-vladimirov added this to the 6.1.0 milestone Aug 19, 2019
@rosen-vladimirov rosen-vladimirov self-assigned this Aug 19, 2019
@cla-bot cla-bot bot added the cla: yes label Aug 19, 2019
@rosen-vladimirov
Copy link
Contributor Author

test cli-smoke cli-misc

@rosen-vladimirov rosen-vladimirov merged commit be3128a into master Aug 19, 2019
@rosen-vladimirov rosen-vladimirov deleted the vladimirov/fix-doctor-err branch August 19, 2019 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants