fix: remove usages of logger.out in CLI code #4959
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`logger.out` has been removed before 6.0 release, but it has still been used in CLI's code. Remove its usages and add tests for `errors.beginCommand` (the one where the method has been used until now.
|
test cli-smoke cli-misc |
| assert.equal(processExitCode, errObj.errorCode, `When the action fails, process.exit must be called with ${errObj.errorCode}.`); | ||
| }); | ||
|
|
||
| it("exits with default exit code code when the error has errorCode set to number", async () => { |
There was a problem hiding this comment.
the test name is wrong - it should be exits with default exit code code when the error has errorCode set to string
|
Closing and will open new one to master branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
logger.outhas been removed before 6.0 release, but it has still been used in CLI's code. Remove its usages and add tests forerrors.beginCommand(the one where the method has been used until now.PR Checklist
What is the current behavior?
ANDROID_HOME=/invalid tns doctor- fails and in interactive terminal prompts you to select option. If you choose Manually configure, CLI will print errorthis.$injector.resolve(...).out is not a function(NOTE: In non-interactive terminal the same happens).What is the new behavior?
ANDROID_HOME=/invalid tns doctor- fails and in interactive terminal prompts you to select option. If you choose Manually configure, CLI will prints where are the system requirements.Fixes issue #4958