fix: "improve this" btn doesn't work for CLI docs #4953
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosen-vladimirov
approved these changes
Aug 19, 2019
Due to changes in the previous commit, `tns -h` is not working as CLI is trying to open the `index.md` file, which does not exist anymore. Change CLI's code to look for `start.md` instead.
rosen-vladimirov
force-pushed
the
etabakov/fix-improvethis
branch
from
7c1dfc1 to
50b111a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
The homepage of the documentation is different in the online version and the local one. This makes it hard to generate a link to the GitHub corresponding file for the "Improve This" button in the online docs.
What is the new behavior?
On both version the homepage is at /start.html. There is a index.html for the local version that redirects to /start.html.
Fixes/Implements/Closes https://github.com/NativeScript/docs/issues/1711.