-
-
Notifications
You must be signed in to change notification settings - Fork 197
fix: include all chunkFiles in fallbackFiles in order to avoid wrong lazy Angular chunks #4925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test cli-smoke cli-run |
rosen-vladimirov
suggested changes
Aug 9, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please relate a relevant issue describing the problem that's fixed with this PR?
0c9fd9a
to
432d4e6
Compare
…lazy Angular chunks
432d4e6
to
ffa256d
Compare
rosen-vladimirov
approved these changes
Aug 9, 2019
test cli-smoke cli-run |
1 similar comment
test cli-smoke cli-run |
test cli-run |
4 similar comments
test cli-run |
test cli-run |
test cli-run |
test cli-run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Related to: #4936