Skip to content

fix: include all chunkFiles in fallbackFiles in order to avoid wrong lazy Angular chunks #4925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 14, 2019

Conversation

DimitarTachev
Copy link
Contributor

@DimitarTachev DimitarTachev commented Aug 1, 2019

PR Checklist

Related to: #4936

@cla-bot cla-bot bot added the cla: yes label Aug 1, 2019
@rosen-vladimirov
Copy link
Contributor

test cli-smoke cli-run

Copy link
Contributor

@rosen-vladimirov rosen-vladimirov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please relate a relevant issue describing the problem that's fixed with this PR?

@DimitarTachev DimitarTachev force-pushed the tachev/fix-lazy-chunks-hmr branch 2 times, most recently from 0c9fd9a to 432d4e6 Compare August 9, 2019 10:42
@DimitarTachev DimitarTachev force-pushed the tachev/fix-lazy-chunks-hmr branch from 432d4e6 to ffa256d Compare August 9, 2019 10:43
@DimitarTachev
Copy link
Contributor Author

test cli-smoke cli-run

1 similar comment
@rosen-vladimirov
Copy link
Contributor

test cli-smoke cli-run

@rosen-vladimirov
Copy link
Contributor

test cli-run

4 similar comments
@rosen-vladimirov
Copy link
Contributor

test cli-run

@rosen-vladimirov
Copy link
Contributor

test cli-run

@rosen-vladimirov
Copy link
Contributor

test cli-run

@rosen-vladimirov
Copy link
Contributor

test cli-run

@rosen-vladimirov rosen-vladimirov merged commit 8bc8868 into release Aug 14, 2019
@rosen-vladimirov rosen-vladimirov deleted the tachev/fix-lazy-chunks-hmr branch August 14, 2019 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants