feat: Support .xcframework bundles #4907

mbektchiev · 2019-07-29T12:55:55Z

PR Checklist

The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages.
There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
You have signed the CLA.
All existing tests are passing: https://github.com/NativeScript/nativescript-cli/blob/master/CONTRIBUTING.md#contribute-to-the-code-base
Tests for the changes are included.

rosen-vladimirov · 2019-08-09T08:31:25Z

test cli-build cli-smoke

Fatme · 2019-08-15T09:55:03Z

lib/services/ios-project-service.ts

 			const frameworkAddOptions: IXcode.Options = { customFramework: true };
-
-			if (isDynamic) {
+			if (this.isDynamicFramework(frameworkPath)) {


Missing await?

mbektchiev added 2 commits July 29, 2019 15:08

feat(iOS): Support .xcframework bundles

7d47700

chore: Delete unused frameworkFilesExtensions property

7516e54

cla-bot bot added the cla: yes label Jul 29, 2019

Fatme added this to the 6.1.0 milestone Jul 29, 2019

rosen-vladimirov approved these changes Aug 12, 2019

View reviewed changes

rosen-vladimirov merged commit 626db9c into master Aug 12, 2019

rosen-vladimirov deleted the feat/support-xcframeworks branch August 12, 2019 15:41

mbektchiev mentioned this pull request Aug 14, 2019

fix(ios): isDynamicFramework check for .xcframeworks #4950

Merged

5 tasks

Fatme reviewed Aug 15, 2019

View reviewed changes