Skip to content

feat: add support for Android SDK 29 for compilation #4895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 13, 2019
Merged

feat: add support for Android SDK 29 for compilation #4895

merged 3 commits into from
Aug 13, 2019

Conversation

KristianDD
Copy link
Contributor

@KristianDD KristianDD commented Jul 24, 2019 •
edited by rosen-vladimirov
Loading

PR Checklist

What is the current behavior?

What is the new behavior?

Implements issue #4926.

@cla-bot cla-bot bot added the cla: yes label Jul 24, 2019
Fatme
Fatme reviewed Jul 24, 2019
View reviewed changes
@KristianDD KristianDD closed this Jul 24, 2019
@KristianDD KristianDD reopened this Jul 24, 2019
@KristianDD KristianDD force-pushed the kddimitrov/refactor-android-tools-info branch from d981d25 to fa10947 Compare July 25, 2019 14:21
@KristianDD
Copy link
Contributor Author

test cli-smoke cli-device cli-debug cli-run

3 similar comments
@KristianDD
Copy link
Contributor Author

test cli-smoke cli-device cli-debug cli-run

@KristianDD
Copy link
Contributor Author

test cli-smoke cli-device cli-debug cli-run

@KristianDD
Copy link
Contributor Author

test cli-smoke cli-device cli-debug cli-run

@Fatme Fatme added this to the 6.1.0 milestone Jul 30, 2019
@KristianDD
Copy link
Contributor Author

test cli-smoke cli-device cli-debug cli-run

4 similar comments
@KristianDD
Copy link
Contributor Author

test cli-smoke cli-device cli-debug cli-run

@KristianDD
Copy link
Contributor Author

test cli-smoke cli-device cli-debug cli-run

@KristianDD
Copy link
Contributor Author

test cli-smoke cli-device cli-debug cli-run

@KristianDD
Copy link
Contributor Author

test cli-smoke cli-device cli-debug cli-run

DimitarTachev
DimitarTachev approved these changes Jul 31, 2019
View reviewed changes
Copy link
Contributor

@DimitarTachev DimitarTachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not forget to update the Doctor version.

@KristianDD KristianDD force-pushed the kddimitrov/refactor-android-tools-info branch 2 times, most recently from 2b8a714 to 4d62411 Compare August 7, 2019 13:11
@KristianDD
Copy link
Contributor Author

test cli-smoke cli-device cli-debug cli-run

2 similar comments
@KristianDD
Copy link
Contributor Author

test cli-smoke cli-device cli-debug cli-run

@rosen-vladimirov
Copy link
Contributor

test cli-smoke cli-device cli-debug cli-run

@rosen-vladimirov rosen-vladimirov force-pushed the kddimitrov/refactor-android-tools-info branch from 4d62411 to 6d4d5cc Compare August 9, 2019 12:15
@rosen-vladimirov
Copy link
Contributor

test cli-device cli-run

1 similar comment
@rosen-vladimirov
Copy link
Contributor

test cli-device cli-run

@rosen-vladimirov
Copy link
Contributor

test cli-run

1 similar comment
@rosen-vladimirov
Copy link
Contributor

test cli-run

@rosen-vladimirov rosen-vladimirov changed the title refactor: extract android tools info logic to doctor feat: add support for Android SDK 29 for compilation Aug 13, 2019
@rosen-vladimirov rosen-vladimirov merged commit fd56fc4 into master Aug 13, 2019
@rosen-vladimirov rosen-vladimirov deleted the kddimitrov/refactor-android-tools-info branch August 13, 2019 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fatme Fatme Fatme left review comments

@DimitarTachev DimitarTachev DimitarTachev approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
6.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@KristianDD @rosen-vladimirov @Fatme @DimitarTachev