Skip to content

fix: fix issues when stopping the livesync process #4871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 17, 2019
Merged

fix: fix issues when stopping the livesync process #4871

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
363bf0f
fix: stop livesync on initial sync when there is an error
Fatme Jul 17, 2019
14fb58b
fix: don't hangs livesync process when there is an error on initial s…
Fatme Jul 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/controllers/run-controller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,6 +330,8 @@ export class RunController extends EventEmitter implements IRunController {
applicationIdentifier: projectData.projectIdentifiers[device.deviceInfo.platform.toLowerCase()],
error: err,
});

await this.stop({ projectDir: projectData.projectDir, deviceIdentifiers: [device.deviceInfo.identifier], stopOptions: { shouldAwaitAllActions: false }});
}
};

Expand Down Expand Up @@ -408,7 +410,7 @@ export class RunController extends EventEmitter implements IRunController {
error: err,
});

await this.stop({ projectDir: projectData.projectDir, deviceIdentifiers: [device.deviceInfo.identifier] });
await this.stop({ projectDir: projectData.projectDir, deviceIdentifiers: [device.deviceInfo.identifier], stopOptions: { shouldAwaitAllActions: false } });
}
};

Expand Down