Enable command autocompletion when local installation is used #486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ |
|
👍 after reasonably approximate to a green build |
When you do not specify -g flag, we could still enable autocompletion, but currently this process fails as we are executing globally installed CLI (for example tns completion >> ...). Use the javascript from bin directory instead. Fix dev-preuninstall command, which was failing due to incorrect service called in it (cancellationService is not called at all, so I removed it. In fact we have $cancellation, not $cancellationService).
rosen-vladimirov
force-pushed
the
vladimirov/autocompletion-enable-local
branch
from
f62829e to
c7f8b3c
Compare
|
✅ |
rosen-vladimirov
added a commit
that referenced
this pull request
May 19, 2015
…nable-local Enable command autocompletion when local installation is used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you do not specify -g flag, we could still enable autocompletion, but currently this process fails as we are executing globally installed CLI (for example tns completion >> ...). Use the javascript from bin directory instead.
Fix dev-preuninstall command, which was failing due to incorrect service called in it (cancellationService is not called at all, so I removed it. In fact we have $cancellation, not $cancellationService).