Skip to content

fix: support node <= 8.9.4 (lookbehind is supported only with the harmony flag) #4854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 16, 2019
Merged

fix: support node <= 8.9.4 (lookbehind is supported only with the harmony flag) #4854

merged 1 commit into from
Jul 16, 2019

Conversation

DimitarTachev
Copy link
Contributor

https://node.green/#ES2018-features--RegExp-Lookbehind-Assertions

PR Checklist

@cla-bot cla-bot bot added the cla: yes label Jul 16, 2019
rosen-vladimirov
rosen-vladimirov approved these changes Jul 16, 2019
View reviewed changes
Copy link
Contributor

@rosen-vladimirov rosen-vladimirov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎈

@vakrilov
Copy link

🎶

@DimitarTachev DimitarTachev merged commit 50ac37b into release Jul 16, 2019
@DimitarTachev DimitarTachev deleted the tachev/support-node8-in-webpack branch July 16, 2019 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vakrilov vakrilov vakrilov approved these changes

@rosen-vladimirov rosen-vladimirov rosen-vladimirov approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DimitarTachev @vakrilov @rosen-vladimirov