Skip to content

fix: update Angular deps during app migration #4852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 16, 2019

Conversation

DimitarTachev
Copy link
Contributor

PR Checklist

What is the current behavior?

The Angular dependencies are not updated during tns migrate causing invalid dependencies state when migrating Angular 5 app. The invalid state is caused by the nativescript-dev-webpack plugin which updates the @angular/compiler-cli and @ngtools/webpack to 8.0.0 which are not compatible with Angular < 7.

What is the new behavior?

tns migrate is not updating the Angular deps in order to ensure compatibiltiy between@angular/compiler-cli, @ngtools/webpack and the rest of the Angular dependencies.

@cla-bot cla-bot bot added the cla: yes label Jul 15, 2019
@DimitarTachev DimitarTachev merged commit 1277156 into release Jul 16, 2019
@DimitarTachev DimitarTachev deleted the tachev/update-angular-on-migrate branch July 16, 2019 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants