fix: final Update and Migrate improvements #4829

DimitarTachev · 2019-07-10T11:04:45Z

PR Checklist

The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages.
There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
You have signed the CLA.
All existing tests are passing: https://github.com/NativeScript/nativescript-cli/blob/master/CONTRIBUTING.md#contribute-to-the-code-base
Tests for the changes are included.

Related to: #4822

…ency when available

lib/controllers/migrate-controller.ts

… during `tns migrate`

cla-bot bot added the cla: yes label Jul 10, 2019

DimitarTachev added 3 commits July 10, 2019 14:07

fix: include nativescript-dev-webpack in the update command

f10b0e5

fix: update versions in the migrate command.

fdb1fe3

fix: avoid a failng migration because of a failing app resources update

19ae3ef

DimitarTachev force-pushed the tachev/include-dev-webpack-in-update branch from 3cd95ae to d679094 Compare July 10, 2019 11:07

fix(migrate): get the TypeScript version from the Angular peer depend…

33bc9ad

…ency when available

DimitarTachev force-pushed the tachev/include-dev-webpack-in-update branch from d679094 to 33bc9ad Compare July 10, 2019 11:08

KristianDD reviewed Jul 10, 2019

View reviewed changes

lib/controllers/migrate-controller.ts Outdated Show resolved Hide resolved

DimitarTachev added 4 commits July 10, 2019 14:42

fix: fix PR comments

7c789d1

fix: fix auto-generated files logs

25afbbf

fix: backup the pre-v4 android app_resources in the .migration_backup…

e795a8b

… during `tns migrate`

fix: reduce the npm calls during migration

c0d4e47

KristianDD approved these changes Jul 10, 2019

View reviewed changes

DimitarTachev merged commit 9e61ab7 into release Jul 10, 2019

DimitarTachev deleted the tachev/include-dev-webpack-in-update branch July 10, 2019 12:25