Skip to content

fix: migrate fails when karma.config.js is missing #4811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 5, 2019
+14 −11
Merged

fix: migrate fails when karma.config.js is missing #4811

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 14 additions & 11 deletions lib/controllers/migrate-controller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,23 +286,26 @@ export class MigrateController extends UpdateControllerBase implements IMigrateC

private async migrateUnitTestRunner(projectData: IProjectData, migrationBackupDirPath: string): Promise<IMigrationDependency[]> {
// Migrate karma.conf.js
const oldKarmaContent = this.$fs.readText(path.join(migrationBackupDirPath, constants.KARMA_CONFIG_NAME));
const pathToKarmaConfig = path.join(migrationBackupDirPath, constants.KARMA_CONFIG_NAME);
if (this.$fs.exists(pathToKarmaConfig)) {
const oldKarmaContent = this.$fs.readText(pathToKarmaConfig);

const regExp = /frameworks:\s+\[([\S\s]*?)\]/g;
const matches = regExp.exec(oldKarmaContent);
const frameworks = (matches && matches[1] && matches[1].trim()) || '["jasmine"]';
const regExp = /frameworks:\s+\[([\S\s]*?)\]/g;
const matches = regExp.exec(oldKarmaContent);
const frameworks = (matches && matches[1] && matches[1].trim()) || '["jasmine"]';

const testsDir = path.join(projectData.appDirectoryPath, 'tests');
const relativeTestsDir = path.relative(projectData.projectDir, testsDir);
const testFiles = `'${fromWindowsRelativePathToUnix(relativeTestsDir)}/**/*.*'`;
const testsDir = path.join(projectData.appDirectoryPath, 'tests');
const relativeTestsDir = path.relative(projectData.projectDir, testsDir);
const testFiles = `'${fromWindowsRelativePathToUnix(relativeTestsDir)}/**/*.*'`;

const karmaConfTemplate = this.$resources.readText('test/karma.conf.js');
const karmaConf = _.template(karmaConfTemplate)({ frameworks, testFiles });
this.$fs.writeFile(path.join(projectData.projectDir, constants.KARMA_CONFIG_NAME), karmaConf);
const karmaConfTemplate = this.$resources.readText('test/karma.conf.js');
const karmaConf = _.template(karmaConfTemplate)({ frameworks, testFiles });
this.$fs.writeFile(path.join(projectData.projectDir, constants.KARMA_CONFIG_NAME), karmaConf);
}

// Dependencies to migrate
const dependencies = [
{ packageName: "karma-webpack", verifiedVersion: "3.0.5", isDev: true, shouldAddIfMissing: !this.hasDependency({ packageName: "karma-webpack", isDev: true }, projectData) },
{ packageName: "karma-webpack", verifiedVersion: "3.0.5", isDev: true, shouldAddIfMissing: true },
{ packageName: "karma-jasmine", verifiedVersion: "2.0.1", isDev: true },
{ packageName: "karma-mocha", verifiedVersion: "1.3.0", isDev: true },
{ packageName: "karma-chai", verifiedVersion: "0.1.0", isDev: true },
Expand Down