Fix xcode version comparison #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -35,6 +35,10 @@ class IOSProjectService implements IPlatformProjectService { | |||
| } | |||
|
|
|||
| var xcodeBuildVersion = this.$childProcess.exec("xcodebuild -version | head -n 1 | sed -e 's/Xcode //'").wait(); | |||
| if(xcodeBuildVersion.split(".").length === 3) { | |||
| xcodeBuildVersion = xcodeBuildVersion.slice(0, -2); | |||
There was a problem hiding this comment.
it is possible that xcode version goes above 10. I would feel much more comfortable if you combine the first two parts from the split string or using a regular expression like /(d+.d+)/ (to capture the first two number parts).
|
👍 |
Fatme
added a commit
that referenced
this pull request
Aug 15, 2014
…arison Fix xcode version comparison
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Xcode version can be 3 numbers separated by dot or 2 numbers separated by dot.
versionComparefunction expects versions in same format. We cannot usesemvermodule because it throws error for versions in "x.y" format.