Skip to content

fix: set the proper root for the auto-generated files glob matching #4792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 2, 2019
+2 −2
Merged

fix: set the proper root for the auto-generated files glob matching #4792

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/controllers/migrate-controller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ export class MigrateController extends UpdateControllerBase implements IMigrateC
matchBase: true,
nodir: true,
absolute: false,
root: projectData.appDirectoryPath
cwd: projectData.appDirectoryPath
};

const jsFiles = glob.sync("*.@(js|ts|js.map)", globOptions);
Expand All @@ -176,7 +176,7 @@ export class MigrateController extends UpdateControllerBase implements IMigrateC

const allGeneratedFiles = autoGeneratedJsFiles.concat(autoGeneratedJsMapFiles).concat(autoGeneratedCssFiles);
for (const generatedFile of allGeneratedFiles) {
const sourceFile = path.join(projectData.projectDir, generatedFile);
const sourceFile = path.join(projectData.appDirectoryPath, generatedFile);
const destinationFile = path.join(backupDir, generatedFile);
const destinationFileDir = path.dirname(destinationFile);
this.$fs.ensureDirectoryExists(destinationFileDir);
Expand Down