Skip to content

fix: handle preview issues #4790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 2, 2019
Merged

Conversation

rosen-vladimirov
Copy link
Contributor

fix: remove debug qr code message

fix: do not start multiple watchers …

In some cases (for example tns preview and scan QR code simultaneously with several devices) we start multiple watchers per platform. We should always have single watcher per platform (one from webpack and one native in fact).

fix: handle preview initial sync once per device …

Handle preview initial sync once per device (in some cases PubNub reports the device multiple times). Also prepare all the files once per platform, not per each device.

PR Checklist

What is the current behavior?

What is the new behavior?

Fixes/Implements/Closes #[Issue Number].

In some cases (for example `tns preview` and scan QR code simultaneously with several devices) we start multiple watchers per platform. We should always have single watcher per platform (one from webpack and one native in fact).
Handle preview initial sync once per device (in some cases PubNub reports the device multiple times). Also prepare all the files once per platform, not per each device.
@rosen-vladimirov rosen-vladimirov self-assigned this Jul 1, 2019
@cla-bot cla-bot bot added the cla: yes label Jul 1, 2019
@rosen-vladimirov
Copy link
Contributor Author

test cli-preview cli-smoke cli-templates

@rosen-vladimirov
Copy link
Contributor Author

test cli-smoke cli-preview tns-core-modules#rc nativescript-dev-webpack#rc android#rc ios#rc tns-android#rc tns-ios#rc

@rosen-vladimirov
Copy link
Contributor Author

test cli-templates tns-core-modules#rc nativescript-dev-webpack#rc android#rc ios#rc tns-android#rc tns-ios#rc

@rosen-vladimirov rosen-vladimirov merged commit 5faf40d into release Jul 2, 2019
@rosen-vladimirov rosen-vladimirov deleted the vladimirov/fix-preview branch July 2, 2019 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants