Skip to content

fix: add package.json files from nativescript plugins to watch patterns #4788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2019

Conversation

Fatme
Copy link
Contributor

@Fatme Fatme commented Jun 30, 2019

Currently CLI respects the changes only in the followings package.json files:

  • package.json from app folder
  • package.json from root folder of the application

The changes from package.json files form NS plugins are not respected as they are not added to the watch's patterns.

PR Checklist

What is the current behavior?

What is the new behavior?

Fixes/Implements/Closes #[Issue Number].

Currently CLI respects the changes only in the followings package.json files:
 * package.json from app folder
 * package.json from root folder of the application
The changes from package.json files form NS plugins are not respected as they are not added to the watch's patterns.
@cla-bot cla-bot bot added the cla: yes label Jun 30, 2019
@Fatme Fatme merged commit 5877dcf into release Jul 1, 2019
@Fatme Fatme deleted the fatme/fix-ns-plugins-package-json branch July 1, 2019 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants