Kddimitrov/fix hanging webpack process #4779
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test cli-templates |
rosen-vladimirov
approved these changes
Jun 27, 2019
|
test cli-templates |
When we run webpack in watch mode and we receive its close event, it means the process had exited and we are not in watch mode anymore. So in this case we have to reject the current promise.
|
test cli-smoke |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
There are cases when the CLI exits, but the webpack process stays alive. Most probably reproducible with TypeScript project.
What is the new behavior?
The CLI makes shure that the webpack process is killed when the
celeanupServiceis disposed.Fixes/Implements/Closes #[Issue Number].