Skip to content

fix: fix "Could not open file Library/Application Support/LiveSync/app/tns_modules/tns-core-modules/inspector_modules.js for writing" error on iOS device when hmr fails #4778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 28, 2019
Merged

fix: fix "Could not open file Library/Application Support/LiveSync/app/tns_modules/tns-core-modules/inspector_modules.js for writing" error on iOS device when hmr fails #4778

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ecfe620
fix: fix "Could not open file Library/Application Support/LiveSync/ap…
Fatme Jun 27, 2019
61ca753
fix: don't create tempApp when zipping the application
Fatme Jun 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions lib/services/livesync/ios-livesync-service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import * as temp from "temp";

import { IOSDeviceLiveSyncService } from "./ios-device-livesync-service";
import { PlatformLiveSyncServiceBase } from "./platform-livesync-service-base";
import { APP_FOLDER_NAME, TNS_MODULES_FOLDER_NAME } from "../../constants";
import { APP_FOLDER_NAME } from "../../constants";
import { performanceLog } from "../../common/decorators";

export class IOSLiveSyncService extends PlatformLiveSyncServiceBase implements IPlatformLiveSyncService {
Expand Down Expand Up @@ -34,8 +34,6 @@ export class IOSLiveSyncService extends PlatformLiveSyncServiceBase implements I
this.$logger.trace("Creating zip file: " + tempZip);
this.$fs.copyFile(path.join(path.dirname(projectFilesPath), `${APP_FOLDER_NAME}/*`), tempApp);

this.$fs.deleteDirectory(path.join(tempApp, TNS_MODULES_FOLDER_NAME));

await this.$fs.zipFiles(tempZip, this.$fs.enumerateFilesInDirectorySync(tempApp), (res) => {
return path.join(APP_FOLDER_NAME, path.relative(tempApp, res));
});
Expand Down